fix: remove version manipulation from build-release.sh#1886
Open
zeitlinger wants to merge 1 commit intomainfrom
Open
fix: remove version manipulation from build-release.sh#1886zeitlinger wants to merge 1 commit intomainfrom
zeitlinger wants to merge 1 commit intomainfrom
Conversation
Release-please already sets the correct versions in pom.xml files at the tagged commit, so the sed-based SNAPSHOT replacement in build-release.sh is redundant and would fail (no SNAPSHOT to find). Remove the TAG argument/env and version manipulation logic, keeping only the Maven package command. Update release and test-release-build workflows to stop passing the TAG env var. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-release.sh— release-please already sets the correct versions in pom.xml at the tagged commitTAGenv var fromrelease.ymlandtest-release-build.ymlworkflowsTest plan
mise run build-releasesucceeds locallymise run lintpasses