Get rid of purescript-string module#57
Merged
Hi-Angel merged 3 commits intopurescript-emacs:masterfrom May 29, 2025
Merged
Conversation
Hi-Angel
force-pushed
the
cleanup-purescript-string
branch
2 times, most recently
from
1645215 to
b624f22
Compare
This is a common helper Emacs had for a while, no need to keep our own function.
It's a small utility function used in one place, and is unlikely used by anyone else. There's no need to keep it autoloaded and in a separate file.
It has just one utility function which is unlikely being used by anyone. Remove it.
Hi-Angel
force-pushed
the
cleanup-purescript-string
branch
from
b624f22 to
baa0714
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module provided 3 small functions, which are not really related to the mode, but for some reason have been "autoloaded". Replace
purescript-trimwith the usualstring-trim, localizepurescript-string-taketo where it's used, and remove unusedpurescript-is-prefix-ofaltogether withpurescript-string.el.