BUG: fix for merge page with annotation #3467

[HSY-999]

see #3467

there are a couple different solutions. this is the one i made.

for my solution, i have to assume that the key name inside DictionaryObject == __init__ parameter names. for example /Vertices and vertices. with these changes the example in #3467 exits normally.

i had to modify the __init__ logic for Polygon and PolyLine, as they both expected tuples which is not the format they are stored in DictionaryObject

if we agree this is acceptable solution, i will also add test case adapted from the issue.

[stefan6419846]

Please have a look at the test failures and add appropriate tests.

Additionally, while your current approach might work for the current cases, I see some limitations/aspects to discuss:

• What happens to keyword-only arguments?
• What happens to unmatched keys?
• What happens to keys which have to be renamed for some reasons, for example because they conflict with an existing name (like a builtin)?

Please provide some details on how you think about this and what your proposals for mitigating them are.

[HSY-999]

* What happens to keyword-only arguments?

it does not work in a small example, but inspect does support matching on keyword arguments in a different list[str] with kwonlyargs. an additional check for this would suffice.

* What happens to unmatched keys?

they are not passed along to __init__ of the class we are trying to clone.

* What happens to keys which have to be renamed for some reasons, for example because they conflict with an existing name (like a builtin)?

good point. i will think on this. i am thinking of having some internal value in DictionaryObject or PdfObject which allow a developer to write its own key value pair if they are not the same.

[HSY-999]

i made changes to the pull request based on feedback. i still need to implement automated test, as well as research renaming keys. i have converted the pull request to a draft and will change the pull request when it is ready for review again.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.16%. Comparing base (2f1b63e) to head (5266c84).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3532   +/-   ##
=======================================
  Coverage   97.15%   97.16%           
=======================================
  Files          56       56           
  Lines        9785     9814   +29     
  Branches     1785     1790    +5     
=======================================
+ Hits         9507     9536   +29     
  Misses        167      167           
  Partials      111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[HSY-999]

i have introduced changes based on feedback. i still need to think about a solution to the keys conflicting with python builtins.

[HSY-999]

i have implemented possible solution for renaming keyword args. @stefan6419846 it is available to review when you are ready.

for the set_alt_arg_name function, you provide it keyword stored in DictionaryObject, and the value is the argument name. for example:

"/Vertices" -> "vertices"