Fix detail::obj_class_name() to work correctly for meta classes.#4436
Merged
rwgk merged 2 commits intopybind:masterfrom Jan 2, 2023
Merged
Fix detail::obj_class_name() to work correctly for meta classes.#4436rwgk merged 2 commits intopybind:masterfrom
detail::obj_class_name() to work correctly for meta classes.#4436rwgk merged 2 commits intopybind:masterfrom
Conversation
Collaborator
Author
Collaborator
Author
|
I'm working on the clang10 C++20 issue under #4438. Ignoring here. |
Skylion007
approved these changes
Jan 2, 2023
Contributor
I guess so. Someday I intend to track this down. When I tried to fix it before I broke pickling of c-extension modules. See the pypy issue. |
henryiii
pushed a commit
that referenced
this pull request
Jan 3, 2023
…4436) * Fix `detail::obj_class_name()` to work correctly for meta classes. * Adjust expected name for PyPy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port of fix here: google/clif@ef64abf
The fix was suggested by @lalaland (#4427 (comment)) and confirmed to be correct by @Yhg1s.
Note that the new test in test_class.py fails without this change.
Suggested changelog entry: