Skip to content

raise on subprocess error #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timkpaine merged 1 commit into from
Feb 27, 2026
Merged

raise on subprocess error #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions hatch_js/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,49 +62,3 @@ def initialize(self, version: str, build_data: dict[str, Any]) -> None:

# Perform any cleanup actions
build_plan.cleanup()

# if build_plan.libraries:
# # force include libraries
# for library in build_plan.libraries:
# name = library.get_qualified_name(build_plan.platform.platform)
# build_data["force_include"][name] = name

# build_data["pure_python"] = False
# machine = platform_machine()
# version_major = version_info.major
# version_minor = version_info.minor
# if "darwin" in sys_platform:
# os_name = "macosx_11_0"
# elif "linux" in sys_platform:
# os_name = "linux"
# else:
# os_name = "win"
# if all([lib.py_limited_api for lib in build_plan.libraries]):
# build_data["tag"] = f"cp{version_major}{version_minor}-abi3-{os_name}_{machine}"
# else:
# build_data["tag"] = f"cp{version_major}{version_minor}-cp{version_major}{version_minor}-{os_name}_{machine}"
# else:
# build_data["pure_python"] = False
# machine = platform_machine()
# version_major = version_info.major
# version_minor = version_info.minor
# # TODO abi3
# if "darwin" in sys_platform:
# os_name = "macosx_11_0"
# elif "linux" in sys_platform:
# os_name = "linux"
# else:
# os_name = "win"
# build_data["tag"] = f"cp{version_major}{version_minor}-cp{version_major}{version_minor}-{os_name}_{machine}"

# # force include libraries
# for path in Path(".").rglob("*"):
# if path.is_dir():
# continue
# if str(path).startswith(str(build_plan.cmake.build)) or str(path).startswith("dist"):
# continue
# if path.suffix in (".pyd", ".dll", ".so", ".dylib"):
# build_data["force_include"][str(path)] = str(path)

# for path in build_data["force_include"]:
# self._logger.warning(f"Force include: {path}")
4 changes: 3 additions & 1 deletion hatch_js/structs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ def execute(self):
chdir(self.path)

for command in self.commands:
system_call(command)
ret = system_call(command)
if ret != 0:
raise RuntimeError(f"hatch-js build command failed with exit code {ret}: {command}")

# Check that all targets exist
# Go back to original path
Expand Down