Skip to content

gh-144849: Unit test fails if ran with Europe/Dublin locale#144850

Closed
notdanhan wants to merge 2 commits intopython:mainfrom
notdanhan:time_fix
Closed

gh-144849: Unit test fails if ran with Europe/Dublin locale#144850
notdanhan wants to merge 2 commits intopython:mainfrom
notdanhan:time_fix

Conversation

@notdanhan
Copy link

@notdanhan notdanhan commented Feb 15, 2026

@python-cla-bot
Copy link

python-cla-bot bot commented Feb 15, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Feb 15, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’ve thought about skipping this test before (which this essentially is), but decided it is better to fix the implementation instead.

@notdanhan
Copy link
Author

notdanhan commented Feb 15, 2026

We’ve thought about skipping this test before (which this essentially is), but decided it is better to fix the implementation instead.

I'm pretty sure that one of the two test assertions I disabled failed because it's implementing ISO 8601 correctly?

(The other ended up checking "GMT" == "IST" but whatever)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants