gh-144849: Unit test fails if ran with Europe/Dublin locale#144850
Closed
notdanhan wants to merge 2 commits intopython:mainfrom
Closed
gh-144849: Unit test fails if ran with Europe/Dublin locale#144850notdanhan wants to merge 2 commits intopython:mainfrom
notdanhan wants to merge 2 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
StanFromIreland
requested changes
Feb 15, 2026
Member
StanFromIreland
left a comment
There was a problem hiding this comment.
We’ve thought about skipping this test before (which this essentially is), but decided it is better to fix the implementation instead.
Author
I'm pretty sure that one of the two test assertions I disabled failed because it's implementing ISO 8601 correctly? (The other ended up checking "GMT" == "IST" but whatever) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lib/tests/test_time.pyif ran withEurope/Dublinlocale #144849