gh-141510: Update specializer to support frozendict#144949
Merged
corona10 merged 1 commit intopython:mainfrom Feb 18, 2026
Merged
gh-141510: Update specializer to support frozendict#144949corona10 merged 1 commit intopython:mainfrom
corona10 merged 1 commit intopython:mainfrom
Conversation
Member
Author
|
@Fidget-Spinner, |
vstinner
approved these changes
Feb 18, 2026
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. Your new PR optimizes two bytecodes instead of just one, and the change is smaller, nice!
In the future, we might use different opcodes for specialized frozendict operations to avoid locking, but we should first measure the performance benefits before considering going that far in terms in optimization. This change is a nice tradeoff between code complexity and performance.
Fidget-Spinner
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.