Skip to content

gh-141510: Fix frozendict.fromkeys() for subclasses#144952

Merged
vstinner merged 6 commits intopython:mainfrom
vstinner:frozendict_fromkeys_copy
Feb 18, 2026
Merged

gh-141510: Fix frozendict.fromkeys() for subclasses#144952
vstinner merged 6 commits intopython:mainfrom
vstinner:frozendict_fromkeys_copy

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 18, 2026

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this option better

@vstinner
Copy link
Member Author

@corona10: I updated the test to apply your suggestions. Please review the updated PR.

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vstinner vstinner enabled auto-merge (squash) February 18, 2026 15:37
@vstinner vstinner merged commit c582ff3 into python:main Feb 18, 2026
45 checks passed
@vstinner vstinner deleted the frozendict_fromkeys_copy branch February 18, 2026 15:56
@vstinner
Copy link
Member Author

A case is not covered by this fix: a dict subclass which returns a frozendict! I wrote #144962 to fix this weird case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments