Skip to content

[Vulkan] Fix Ninja build failure by removing wildcard dependencies #16394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Peddinti-Sriram-Bharadwaj wants to merge 16 commits into
base: main
Choose a base branch
from
+6 −1
Open

[Vulkan] Fix Ninja build failure by removing wildcard dependencies #16394

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
49727fb
Fix Ninja build error: explicit glob for Vulkan shaders
Peddinti-Sriram-Bharadwaj Dec 25, 2025
738dcc1
Merge pull request #1 from Peddinti-Sriram-Bharadwaj/fix/ninja-wildca…
Peddinti-Sriram-Bharadwaj Dec 25, 2025
9e065b4
trigger ci
Peddinti-Sriram-Bharadwaj Dec 25, 2025
bba1582
chore: trigger lintrunner check
Peddinti-Sriram-Bharadwaj Dec 25, 2025
8aaa477
Merge branch 'main' into main
Peddinti-Sriram-Bharadwaj Dec 27, 2025
6766e22
Merge branch 'main' into main
Peddinti-Sriram-Bharadwaj Dec 29, 2025
b2ddd68
fix: modified vulkan shaders glob pattern to be exhaustive
Peddinti-Sriram-Bharadwaj Dec 29, 2025
f8527f1
Merge branch 'main' into main
Peddinti-Sriram-Bharadwaj Dec 29, 2025
60cbba0
Merge branch 'pytorch:main' into main
Peddinti-Sriram-Bharadwaj Dec 30, 2025
eecc2d9
Merge branch 'pytorch:main' into fix/ninja-wildcard-shader-library
Peddinti-Sriram-Bharadwaj Dec 30, 2025
2c89106
Merge branch 'main' into fix/ninja-wildcard-shader-library
Peddinti-Sriram-Bharadwaj Dec 30, 2025
dfb2b19
Merge pull request #2 from Peddinti-Sriram-Bharadwaj/fix/ninja-wildca…
Peddinti-Sriram-Bharadwaj Dec 30, 2025
e8606eb
Merge branch 'main' into main
Peddinti-Sriram-Bharadwaj Dec 31, 2025
1e8ee25
[Vulkan] Fix lintrunner formatting issues
Peddinti-Sriram-Bharadwaj Jan 3, 2026
519d9da
Merge pull request #3 from Peddinti-Sriram-Bharadwaj/fix/ninja-wildca…
Peddinti-Sriram-Bharadwaj Jan 3, 2026
0a5df8a
Merge branch 'pytorch:main' into main
Peddinti-Sriram-Bharadwaj Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion backends/vulkan/cmake/ShaderLibrary.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ function(gen_vulkan_shader_lib_cpp shaders_path)
)
endif()

# Ninja cannot expand wildcards (*) in DEPENDS lists.
file(GLOB VULKAN_SHADERS "${shaders_path}/*.glsl" "${shaders_path}/*.glslh"
"${shaders_path}/*.yaml" "${shaders_path}/*.h"
)

add_custom_command(
COMMENT "Generating Vulkan Compute Shaders"
OUTPUT ${VULKAN_SHADERGEN_OUT_PATH}/spv.cpp
Expand All @@ -70,7 +75,7 @@ function(gen_vulkan_shader_lib_cpp shaders_path)
--glslc-path=${GLSLC_PATH}
--tmp-dir-path=${VULKAN_SHADERGEN_OUT_PATH}/shader_cache/ --env
${VULKAN_GEN_ARG_ENV} ${GEN_SPV_ARGS}
DEPENDS ${shaders_path}/*
DEPENDS ${VULKAN_SHADERS}
${EXECUTORCH_ROOT}/backends/vulkan/runtime/gen_vulkan_spv.py
)

Expand Down