-
Notifications
You must be signed in to change notification settings - Fork 217
Code cleanup of XPU profiler for incoming scope profiler #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@EikanWang, @gujinghui |
|
@sraikund16 Could you help review this PR? Thanks. |
|
@sraikund16, could you review or suggest who else could do it ? |
|
@malfet could you help review this PR? Thanks. |
|
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this in D88693420. |
aaronenyeshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
|
@moksiuc has updated the pull request. You must reimport the pull request before landing. |
|
@sraikund16 done |
|
@sraikund16 how to run linter in this repo so I had correct format the next time ? |
Unfortunately we don't have a linter in Kineto externally. We plan on adding it in the coming half |
|
@sraikund16 merged this pull request in 2a430df. |
Summary:
Code cleanup of XPU profiler plugin to prepare it for incoming PR with implementation of XPU scope profiler.
Changes: