Add FBConfig to set PERFETTO_BUILDER_ENABLED from JK as feature toggle #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzzchy
force-pushed
the
export-D88709345
branch
from
6b0ab63 to
67bad9a
Compare
Summary: Discussed with sraikund16, instead of building from proto file, we pre-built the header and cpp so that we could use it in both OSS and FB flow Differential Revision: D88919648
pytorch#1196) Summary: AT, config the ENV variable based on JustKnob as feature toggle. Differential Revision: D88709345
mzzchy
force-pushed
the
export-D88709345
branch
from
67bad9a to
31ce82c
Compare
|
This pull request has been merged in 883a6a2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: AT, config the ENV variable based on JustKnob as feature toggle.
Differential Revision: D88709345