-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Modernize the Ray Tune tutorial #3694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ate code block formatting from text to bash.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3694
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
cc @xinyuangui2 |
xinyuangui2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from ray tune side.
|
@svekars Ready for review from the PyTorch side :) |
|
Happy new year @svekars . Gentle bump on the review on this PR. This one is soft blocking other contributions because of the Ray version bump. |
|
Thanks for the reminder! Will review today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see that now it takes 32 minutes to build this tutorial while the current version takes 12 minutes. Can we reduce the time of the build? We could try to put on a different worker and see if it helps.
|
@svekars I made the following changes to speed up the tutorial:
|
svekars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I added a couple of very minor formatting comments! Thank you for adjusting the execution time and updating the tutorial!
Co-authored-by: Svetlana Karslioglu <[email protected]>
This is the first of several PRs against the Pytorch Tutorials. This PR unstales the Ray Tune tutorial:
Ray-Distributedtag.Opening this as a draft PR so that I can get feedback from the Ray Tune core devs first
cc @subramen @albanD @jbschlosser @pcmoritz @robertnishihara @matthewdeng @richardliaw