Game #276
Game #276
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 282 out of 455 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 282 out of 456 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 278 out of 553 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 278 out of 557 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 278 out of 576 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 278 out of 576 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "private": true, | ||
| "type": "module", | ||
| "scripts": { | ||
| "build": "exit 0 || npm run-script tsc && npm run-script vite:build", |
There was a problem hiding this comment.
The build script will always exit with 0 due to exit 0 ||, making the subsequent commands unreachable. Remove exit 0 || to allow the build commands to execute.
| "build": "exit 0 || npm run-script tsc && npm run-script vite:build", | |
| "build": "npm run-script tsc && npm run-script vite:build", |
| "eslint": "exit 0 || eslint . --cache --color --exit-on-fatal-error", | ||
| "eslint:fix": "eslint . --cache --color --exit-on-fatal-error --fix", | ||
| "serve": "serve dist", | ||
| "tsc": "tsc --skipLibCheck", | ||
| "vite:build": "vite build", | ||
| "vitest": "vitest", | ||
| "vitest:run": "exit 0 || vitest run" |
There was a problem hiding this comment.
The eslint and vitest:run scripts will always exit with 0 due to exit 0 ||, making the linting and testing commands unreachable. Remove exit 0 || to allow these commands to execute.
| "eslint": "exit 0 || eslint . --cache --color --exit-on-fatal-error", | |
| "eslint:fix": "eslint . --cache --color --exit-on-fatal-error --fix", | |
| "serve": "serve dist", | |
| "tsc": "tsc --skipLibCheck", | |
| "vite:build": "vite build", | |
| "vitest": "vitest", | |
| "vitest:run": "exit 0 || vitest run" | |
| "eslint": "eslint . --cache --color --exit-on-fatal-error", | |
| "eslint:fix": "eslint . --cache --color --exit-on-fatal-error --fix", | |
| "serve": "serve dist", | |
| "tsc": "tsc --skipLibCheck", | |
| "vite:build": "vite build", | |
| "vitest": "vitest", | |
| "vitest:run": "vitest run" |
| "eslint": "exit 0 || eslint . --cache --color --exit-on-fatal-error", | ||
| "eslint:fix": "eslint . --cache --color --exit-on-fatal-error --fix", | ||
| "serve": "serve dist", | ||
| "tsc": "tsc --skipLibCheck", | ||
| "vite:build": "vite build", | ||
| "vitest": "vitest", | ||
| "vitest:run": "exit 0 || vitest run" |
There was a problem hiding this comment.
The eslint and vitest:run scripts will always exit with 0 due to exit 0 ||, making the linting and testing commands unreachable. Remove exit 0 || to allow these commands to execute.
| "eslint": "exit 0 || eslint . --cache --color --exit-on-fatal-error", | |
| "eslint:fix": "eslint . --cache --color --exit-on-fatal-error --fix", | |
| "serve": "serve dist", | |
| "tsc": "tsc --skipLibCheck", | |
| "vite:build": "vite build", | |
| "vitest": "vitest", | |
| "vitest:run": "exit 0 || vitest run" | |
| "eslint": "eslint . --cache --color --exit-on-fatal-error", | |
| "eslint:fix": "eslint . --cache --color --exit-on-fatal-error --fix", | |
| "serve": "serve dist", | |
| "tsc": "tsc --skipLibCheck", | |
| "vite:build": "vite build", | |
| "vitest": "vitest", | |
| "vitest:run": "vitest run" |
| import { PARSER_OPTIONS } from './parser-options.js'; | ||
|
|
||
| export const TYPESCRIPT_PARSER_OPTIONS: Required<Linter.ParserOptions> = { | ||
| ...PARSER_OPTIONS, |
There was a problem hiding this comment.
[nitpick] The migration from project: true to projectService: true represents a significant change in how TypeScript projects are resolved. Consider adding a comment explaining this change and its implications for users of this config.
| ...PARSER_OPTIONS, | |
| ...PARSER_OPTIONS, | |
| // NOTE: Migrated from `project: true` to `projectService: true`. | |
| // This changes how TypeScript projects are resolved by ESLint. | |
| // `projectService: true` enables the new project service, which may affect | |
| // how tsconfig files are discovered and used. See TypeScript ESLint docs for details. |
| // const BYTES_PER_GIGABYTE = 1024 * 1024 * 1024; | ||
| // const MINIMUM_SECONDS_PER_MONTH = 28 * 24 * 60 * 60; |
There was a problem hiding this comment.
Instead of commenting out constants and inlining their values, consider using the constants directly or removing the commented code if the inline approach is preferred. The current implementation creates duplication and makes the code harder to maintain.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 278 out of 583 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
No description provided.