add "Parameters Used" section in html report #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parameters for further reference.
- Removed redundant dropna() calls in avg_return and avg_loss functions - Simplified conditional logic in cvar function for better readability - Fixed quantile_mean calculation in tail_ratio functions - Ensured consistent handling of NaN values across all statistical functions
- Wrap r_squared result in list and append dash for consistency - Wrap information_ratio result in list and append dash for consistency - Ensure proper formatting of metrics when returns is a Series
- Removed redundant dropna() calls in avg_return and avg_loss functions - Simplified conditional logic in cvar function for better readability - Fixed quantile_mean calculation in tail_ratio functions - Ensured consistent handling of NaN values across all statistical functions (cherry picked from commit 86a60b3)
- Wrap r_squared result in list and append dash for consistency - Wrap information_ratio result in list and append dash for consistency - Ensure proper formatting of metrics when returns is a Series (cherry picked from commit 3bed2fd)
- Added .round(2) to R^2 metric calculation for better readability - Added .round(2) to Information Ratio metric calculation for consistency- Maintained existing structure and formatting of metrics dictionary - Ensured compatibility with both Series and DataFrame return types
- Drop NaN values before processing returns data
- Fix incorrect assignment of Omega values for pandas Series returns - Ensure consistent handling of benchmark Omega when present - Maintain proper structure for metrics dictionary output
# Conflicts: # quantstats/reports.py
- Remove redundant DataFrame conversion for returns data - Add isinstance check to ensure proper handling of DataFrame inputs - Improve figure size calculation logic for multi-column returns - Maintain compatibility with both Series and DataFrame return types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add "Parameters Used" section in html report, user can store notes or parameters for further reference.