Add missing headers to row_ir.hpp, row_ir.cpp #20834
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
force-pushed
the
fix-row-ir-missing-headers
branch
from
0c0aedd to
e1b2ff3
Compare
bdice
changed the title
kingcrimsontianyu
approved these changes
Dec 11, 2025
Contributor
kingcrimsontianyu
left a comment
kingcrimsontianyu
left a comment
There was a problem hiding this comment.
Looks good. Just curious why plain libcudf can build without these headers. Does the version of g++/nvcc used in libcudf container tolerate missing STL headers?
Contributor
Author
|
@kingcrimsontianyu This doesn't fail in our normal CI builds, probably due to different compiler versions OR different dependency versions that indirectly include the missing headers. However, it is always recommended & correct to Include What You Use (IWYU). |
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing standard library and RMM headers to
cpp/src/jit/row_ir.hppandrow_ir.cpp. Found while compiling Gluten-Velox.