Update index.js#67
Open
claudiaTonak wants to merge 1 commit intoreact-native-web-community:masterfrom
Open
Conversation
supress scrollbar if scrollEnabled is false
Minishlink
reviewed
Jun 21, 2022
| allowpaymentrequest: 'true', | ||
| frameBorder: '0', | ||
| seamless: true, | ||
| scrollEnabled?'yes':'no', |
Member
There was a problem hiding this comment.
I doubt you tested this code
Author
|
I did
Von: Louis Lagrange ***@***.***>
Gesendet: Dienstag, 21. Juni 2022 16:32
An: react-native-web-community/react-native-web-webview ***@***.***>
Cc: Tonak, Claudia ***@***.***>; Author ***@***.***>
Betreff: Re: [react-native-web-community/react-native-web-webview] Update index.js (PR #67)
@Minishlink commented on this pull request.
________________________________
In src/index.js<#67 (comment)>:
@@ -129,6 +129,7 @@ export class WebView extends Component {
allowpaymentrequest: 'true',
frameBorder: '0',
seamless: true,
+ scrollEnabled?'yes':'no',
I doubt you tested this code
—
Reply to this email directly, view it on GitHub<#67 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXIXQNUQ2CN2JTQCXXD2NIDVQHG7PANCNFSM5ZI6MFCQ>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Author
|
What’s wrong with my changes? Works like a charm here.
I tried to eleminate the scrollbars of an iframe. An iframe needs a
<iframe scrolling=‘no‘
to suppress the scrollbars
My changes oft the arguments in createElement with scrolling: scrollEnabled ? 'yes' : 'no' did the job for me.
Von: Tonak, Claudia
Gesendet: Dienstag, 21. Juni 2022 16:34
An: react-native-web-community/react-native-web-webview ***@***.***>
Betreff: AW: [react-native-web-community/react-native-web-webview] Update index.js (PR #67)
I did
Von: Louis Lagrange ***@***.******@***.***>>
Gesendet: Dienstag, 21. Juni 2022 16:32
An: react-native-web-community/react-native-web-webview ***@***.******@***.***>>
Cc: Tonak, Claudia ***@***.******@***.***>>; Author ***@***.******@***.***>>
Betreff: Re: [react-native-web-community/react-native-web-webview] Update index.js (PR #67)
@Minishlink commented on this pull request.
________________________________
In src/index.js<#67 (comment)>:
@@ -129,6 +129,7 @@ export class WebView extends Component {
allowpaymentrequest: 'true',
frameBorder: '0',
seamless: true,
+ scrollEnabled?'yes':'no',
I doubt you tested this code
—
Reply to this email directly, view it on GitHub<#67 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXIXQNUQ2CN2JTQCXXD2NIDVQHG7PANCNFSM5ZI6MFCQ>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supress scrollbar if scrollEnabled is false