Skip to content

ENG-8908: Blog cards updates#1763

Merged
Alek99 merged 3 commits intomainfrom
carlos/blog-cards
Feb 27, 2026
Merged

ENG-8908: Blog cards updates#1763
Alek99 merged 3 commits intomainfrom
carlos/blog-cards

Conversation

@carlosabadia
Copy link
Collaborator

No description provided.

@linear
Copy link

linear bot commented Feb 25, 2026

@carlosabadia carlosabadia marked this pull request as ready for review February 27, 2026 14:24
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

This PR adds blog post categorization and filtering functionality to the blog page. All 27 blog posts now have tag fields (Announcements, Open Source, Builder, Cloud) added to their frontmatter. The main blog page (blog.py) was significantly refactored to include:

  • Client-side filtering using ClientStateVar to filter posts by category
  • A newsletter signup form integrated into the filter bar
  • Redesigned blog card layout with updated styling
  • Removed the special "first post" card layout

Additionally, the PR migrates the about page from @rx.page to @marketing_page decorator and consolidates hosting banner padding logic into the marketing page template.

Issues Found:

  • CSS typo: items center should be items-center on line 37
  • Function name typo: newletter_input should be newsletter_input on lines 39 and 51
  • CSS typo: bakdrop-blur should be backdrop-blur on line 128
  • Missing null-safety check for meta["tag"] on line 131 (will cause KeyError if a blog post lacks a tag field)

Confidence Score: 2/5

  • This PR has several syntax errors that will cause runtime issues and should be fixed before merging
  • The PR includes 5 critical issues in blog.py: 3 CSS typos that will prevent proper styling, 1 function name typo used in 2 places, and 1 logic error that could cause a KeyError at runtime. While the overall architecture and approach are sound, these syntax and logic errors need to be resolved
  • pcweb/pages/blog/blog.py requires immediate attention to fix CSS typos, function name typo, and add null-safety check for tag field

Important Files Changed

Filename Overview
pcweb/pages/blog/blog.py Major refactoring with new filtering UI and newsletter signup. Found 5 critical issues: CSS typos, function name typo, and missing null-safety check for tag field
pcweb/pages/blog/page.py Added tag display to blog post breadcrumb and removed conditional padding logic. Clean implementation
pcweb/templates/marketing_page.py Added conditional top margin based on hosting banner visibility. Properly uses HostingBannerState
pcweb/pages/about/init.py Converted from @rx.page to @marketing_page decorator, removed manual navbar integration. Cleaner structure
pcweb/pages/about/views/hero.py Removed conditional padding logic for hosting banner, simplified to static padding. Cleaner code
pcweb/pages/init.py Renamed export from about to about_page to match refactored function name

Last reviewed commit: aef21a8

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

33 files reviewed, 5 comments

Edit Code Review Agent Settings | Greptile

@Alek99 Alek99 merged commit db9058b into main Feb 27, 2026
10 checks passed
@Alek99 Alek99 deleted the carlos/blog-cards branch February 27, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants