Use homogenous tuple annotation in BaseStateMeta.__new__#6096
Merged
Conversation
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes |
Contributor
Greptile SummaryCorrected type annotation in
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Python as Python Interpreter
participant Meta as BaseStateMeta
participant Type as type/ABCMeta
Note over Python,Type: Class Definition Phase
Python->>Meta: __new__(cls, name, bases, namespace, mixin)
Note over Meta: bases: tuple[type, ...]<br/>(0 or more base classes)
Meta->>Meta: Extract state_bases from bases
Meta->>Meta: Process inherited_fields from bases
Meta->>Meta: Process own_fields from namespace
Meta->>Type: super().__new__(cls, name, bases, namespace)
Type-->>Meta: New class instance
Meta-->>Python: Return configured class
|
| cls, | ||
| name: str, | ||
| bases: tuple[type], | ||
| bases: tuple[type, ...], |
Contributor
There was a problem hiding this comment.
style: Same issue exists in reflex/components/field.py:70 where FieldBasedMeta.__new__ still uses tuple[type] instead of tuple[type, ...]
Prompt To Fix With AI
This is a comment left during a code review.
Path: reflex/vars/base.py
Line: 3540:3540
Comment:
**style:** Same issue exists in `reflex/components/field.py:70` where `FieldBasedMeta.__new__` still uses `tuple[type]` instead of `tuple[type, ...]`
How can I resolve this? If you propose a fix, please make it concise.
adhami3310
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.