ENG-7587: moveing enterprise componnets to templates#116
Open
LineIndent wants to merge 4 commits intomainfrom
Open
ENG-7587: moveing enterprise componnets to templates#116LineIndent wants to merge 4 commits intomainfrom
LineIndent wants to merge 4 commits intomainfrom
Conversation
masenf
reviewed
Sep 22, 2025
Collaborator
masenf
left a comment
masenf
left a comment
There was a problem hiding this comment.
can you go through and fix the deprecation warnings that are now checked in CI for all template apps?
i won't block on the following, but it would be nice if we had a bit better integration of the examples with the sidebar.
additionally, each example has it's own common.py that are basically identical and should be factored out and shared among all of the examples.
ideally the sidebar and drop down stuff would all be sharable among all the sub apps and adding a new demo would be as simple as putting the demo decorator on a component-returning function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.