fall back to web when maDisplayTool is not a sibling#31
fall back to web when maDisplayTool is not a sibling#31
Conversation
The generate-arena-config.js script assumes, that maDisplayTools lives in a sibling folder. If this isn't the case, this new version downloads the most recent version from github. Possibly this could be the default? If I run this right now, I get one more arena: G6_3x16_full
|
this change brings in a hardcoded branch name (feature/g6-tools)...I was planning to merge this stuff to main (in that repo) by the weekend, so maybe it's better to wait a few days and, as suggested, use the maDisplayTool as the default at that time? |
|
Yes, that would be better than the current suggestion. |
mbreiser
left a comment
There was a problem hiding this comment.
Good feature — the GitHub fallback download is a solid improvement for portability.
Issue: The generateOutput() template in the PR is outdated compared to the current arena-configs.js on main. The current file includes additional exports (GENERATIONS, ARENA_REGISTRY, getGenerationName(), getGenerationId(), getArenaName(), getArenaId()) that were added after this PR was created. Running the updated script would overwrite these with a simpler version.
Suggestion: Rebase onto current main and update the output template in generateOutput() to match the current arena-configs.js structure (including all new exports and the registry pattern). The new G6_3x16_full config is already on main.
The generate-arena-config.js script assumes, that maDisplayTools lives in a sibling folder. If this isn't the case, this new version downloads the most recent version from github. Possibly this could be the default?
If I run this right now, I get one more arena: G6_3x16_full