Skip to content

fall back to web when maDisplayTool is not a sibling#31

Draft
floesche wants to merge 4 commits intomainfrom
feature/maDisplayToolDependency
Draft

fall back to web when maDisplayTool is not a sibling#31
floesche wants to merge 4 commits intomainfrom
feature/maDisplayToolDependency

Conversation

@floesche
Copy link
Member

@floesche floesche commented Feb 5, 2026

The generate-arena-config.js script assumes, that maDisplayTools lives in a sibling folder. If this isn't the case, this new version downloads the most recent version from github. Possibly this could be the default?

If I run this right now, I get one more arena: G6_3x16_full

The generate-arena-config.js script assumes, that maDisplayTools lives
in a sibling folder. If this isn't the case, this new version downloads
the most recent version from github. Possibly this could be the default?

If I run this right now, I get one more arena: G6_3x16_full
@mbreiser
Copy link
Contributor

mbreiser commented Feb 5, 2026

this change brings in a hardcoded branch name (feature/g6-tools)...I was planning to merge this stuff to main (in that repo) by the weekend, so maybe it's better to wait a few days and, as suggested, use the maDisplayTool as the default at that time?

@floesche
Copy link
Member Author

floesche commented Feb 5, 2026

Yes, that would be better than the current suggestion.

Copy link
Contributor

@mbreiser mbreiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature — the GitHub fallback download is a solid improvement for portability.

Issue: The generateOutput() template in the PR is outdated compared to the current arena-configs.js on main. The current file includes additional exports (GENERATIONS, ARENA_REGISTRY, getGenerationName(), getGenerationId(), getArenaName(), getArenaId()) that were added after this PR was created. Running the updated script would overwrite these with a simpler version.

Suggestion: Rebase onto current main and update the output template in generateOutput() to match the current arena-configs.js structure (including all new exports and the registry pattern). The new G6_3x16_full config is already on main.

@floesche floesche marked this pull request as draft February 11, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants