Conversation
mbreiser
reviewed
Feb 11, 2026
Contributor
mbreiser
left a comment
mbreiser
left a comment
There was a problem hiding this comment.
CI passes, looks good. PR #30 (Prettier config) is already merged so this is ready to go.
One consideration: we're about to make changes to pattern_editor.html and js/three-viewer.js for issue #29. Merging this formatting PR before or after that work will create merge conflicts either way, so we may want to coordinate timing.
> prettier --write "**/*.js" js/arena-calculations.js 41ms (unchanged) js/arena-configs.js 20ms (unchanged) js/arena-geometry.js 24ms (unchanged) js/g6-encoding.js 18ms (unchanged) js/gif.worker.js 62ms (unchanged) js/icon-generator.js 37ms (unchanged) js/pat-encoder.js 30ms (unchanged) js/pat-parser.js 29ms (unchanged) js/pattern-editor/tools/combiner.js 8ms (unchanged) js/pattern-editor/tools/generator.js 28ms (unchanged) js/pattern-editor/tools/image-converter.js 13ms (unchanged) js/pattern-editor/viewers/three-viewer.js 35ms (unchanged) scripts/generate-arena-configs.js 9ms (unchanged) test_patparser_node.js 4ms (unchanged) tests/generate-roundtrip-patterns.js 12ms (unchanged) tests/validate-arena-calculations.js 5ms (unchanged) tests/validate-arena-geometry.js 11ms (unchanged) tests/validate-comprehensive-reference.js 6ms (unchanged) tests/validate-g6-encoding.js 9ms (unchanged) tests/validate-header-v2.js 11ms (unchanged) tests/validate-matlab-reference.js 9ms (unchanged) tests/validate-pattern-generation.js 13ms (unchanged) tests/validate-spherical-grating.js 11ms (unchanged) on new scripts
Member
Author
|
I ran prettier on the new scripts from main as well. The earlier this PR gets into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ran the prettier formatter on the JS files. If you choose to accept #30, this could make it easier to track changes later.