-
Notifications
You must be signed in to change notification settings - Fork 1
Allow CMKs and bucket keys #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allan-thatch
added a commit
to thatch-health/render-auditlogs
that referenced
this pull request
Dec 18, 2025
Add support for using customer-managed KMS keys and bucket keys for encryption. This is a fork version of render-examples#2.
|
Great addition! Our current s3 bucket policy will actually block KMS-encrypted uploads because it requires AES256 encryption. When using KMS, the encryption type is "aws:kms". |
Contributor
Author
|
Great catch! Thank you! |
SEANDOUGHTY
requested changes
Jan 6, 2026
SEANDOUGHTY
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for using customer-managed KMS keys and bucket keys for encryption.