Skip to content

Conversation

@abey79
Copy link
Member

@abey79 abey79 commented Dec 10, 2025

Related

What

TODO

Implementation note:

  • The DataframeQueryViewProvider-related code now lives in DatasetView, with Dataset.reader() delegating to DatasetView.reader().
  • This still uses the OLD semantics for using_index_values, aka. a list of index value that are applied equally to every single selected segment. Moving to the new semantics (mapping of segment id -> list of index values) requires changes to the DataframeQueryTableProvider, so that's for the next PR.
  • This PR doesn't yet implement get_index_range on Dataset/DatasetView

@abey79 abey79 changed the base branch from main to antoine/api-update-4-schema December 10, 2025 09:33
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Latest documentation preview deployed successfully.

Result Commit Link
30d37f0 https://landing-jxkmytcn4-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Web viewer built successfully.

Result Commit Link Manifest
30d37f0 https://rerun.io/viewer/pr/12151 +nightly +main

View image diff on kitdiff.

Note: This comment is updated whenever you push a commit.

Base automatically changed from antoine/api-update-4-schema to main December 10, 2025 09:56
@abey79 abey79 force-pushed the antoine/api-update-5-dataset-view branch from 3e3e40d to 591a8ea Compare December 10, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants