Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REST requests (SecureHttpClient, RestImageUploadService) — API key now sent as X-API-Key header instead of in the URL. The URL itself is clean (/api/whoami.json
instead of /api/whoami.json?api_key=secret).
WebSocket connections — On native platforms (iOS/Android/desktop), the api_key query param is no longer added to the WebSocket URI. Authentication relies on the
Authorization: Bearer header that was already being passed but redundant. On web, we keep the query param as a fallback because browser WebSocket API
doesn't support custom headers.
Image loading — Instead of appending ?api_key=... to every image URL (which gets cached, logged, and visible in network tools), we pass X-API-Key via the
httpHeaders parameter on CachedNetworkImage, so the credential travels in headers only.