refactor: output idiomatic boolean attributes in JSX#432
Open
faridreaming wants to merge 1 commit intoritz078:masterfrom
Open
refactor: output idiomatic boolean attributes in JSX#432faridreaming wants to merge 1 commit intoritz078:masterfrom
faridreaming wants to merge 1 commit intoritz078:masterfrom
Conversation
|
@faridreaming is attempting to deploy a commit to the ritesh-oss Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the HTML-to-JSX conversion produces non-idiomatic JSX for boolean attributes (e.g.,
required=""instead of justrequired). This happens because the underlyinghtmltojsxpackage is no longer maintained.This PR adds a post-processing step to clean up these attributes using a predefined list of HTML5 boolean attributes.
Changes
constants/jsxAttributes.tsto store a comprehensive list of boolean attributes and a reusable Regex.pages/html-to-jsx.tsxto apply the cleanup logic after the initial conversion.Testing
<input required="" disabled="" /><input required disabled />id=""orclassName) remain untouched.