[tmva][sofie] Fix Keras BinaryOp test model shapes and improve reproducibility#20875
Open
Shlok-Saxena wants to merge 1 commit intoroot-project:masterfrom
Open
[tmva][sofie] Fix Keras BinaryOp test model shapes and improve reproducibility#20875Shlok-Saxena wants to merge 1 commit intoroot-project:masterfrom
Shlok-Saxena wants to merge 1 commit intoroot-project:masterfrom
Conversation
sanjibansg
reviewed
Jan 30, 2026
Collaborator
sanjibansg
left a comment
sanjibansg
left a comment
There was a problem hiding this comment.
Hi @Shlok-Saxena ,
Thanks for your PR. I have one comment.
Comment on lines
+122
to
+124
| x1_train = randomGenerator.rand(2,2) | ||
| x2_train = randomGenerator.rand(2,2) | ||
| y_train = randomGenerator.rand(2,2) |
Collaborator
There was a problem hiding this comment.
Probably I am missing something, but why do we need this change? The input asks for tensors of shape (2,) which should work fine with inputs shaped (2,1) right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request
Fixes a shape mismatch in the Keras test model generator used for SOFIE tests and improves reproducibility of generated models.
Changes or fixes:
generateBinaryOpModel()from(2,1)to(2,2)to match the model input signatureInput(shape=(2,))tf.keras.utils.set_random_seed(0)so model initialization and generated outputs are reproducible across runs, improving stability of SOFIE Keras parser tests.Checklist: