[hist] Add RBinIndex conversion overloads#20879
Merged
hahnjo merged 2 commits intoroot-project:masterfrom Jan 16, 2026
Merged
Conversation
This avoids sign conversion warnings for signed integers, for example from literals. We then need all overloads to guarantee one unambiguous constructor candidate following integer promotion.
bellenot
approved these changes
Jan 14, 2026
Member
bellenot
left a comment
bellenot
left a comment
There was a problem hiding this comment.
I confirm this PR fixes the warnings on Windows. Thanks Jonas!
Test Results 23 files 23 suites 3d 22h 25m 4s ⏱️ Results for commit 1f3840e. ♻️ This comment has been updated with latest results. |
hageboeck
approved these changes
Jan 15, 2026
Member
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
It doesn't look great, but it seems to be the safest way to avoid all the warnings. 🥲
👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids sign conversion warnings for signed integers, for example from literals. We then need all overloads to guarantee one unambiguous constructor candidate following integer promotion.