[cling][test] Fix failing cling tests in master#21232
Merged
devajithvs merged 4 commits intoroot-project:masterfrom Feb 11, 2026
Merged
[cling][test] Fix failing cling tests in master#21232devajithvs merged 4 commits intoroot-project:masterfrom
devajithvs merged 4 commits intoroot-project:masterfrom
Conversation
devajithvs
force-pushed
the
cling-failing
branch
from
cb48ffa to
379c515
Compare
Test Results 22 files 22 suites 3d 9h 32m 47s ⏱️ Results for commit 6851cc3. ♻️ This comment has been updated with latest results. |
When cling is built with C++17, the implementation in ValuePrinter.cpp is not compiled. When cling is later used with -std=c++20, we don't have the implementation to print `source_location`
Fix the following assertion failure in cling: ``` [cling]$ #include <filesystem> Transaction.cpp:180: void cling::Transaction::forceAppend(DelayCallInfo): Assertion `oldDCI != DCI && "Duplicates?!"' failed. ```
LLVM relies on libedit for line editing. History and other input functionalities might not work as expected without this.
devajithvs
force-pushed
the
cling-failing
branch
from
379c515 to
6851cc3
Compare
This was referenced Feb 13, 2026
Member
|
This PR has been backported to branch 6.38: #21273 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Fixes failng tests in cling when compiled with assertions enabled.
Changes or fixes:
Checklist:
This PR fixes #