[RDF] Fix display of times in the progress bar.#21277
Merged
hageboeck merged 1 commit intoroot-project:masterfrom Feb 16, 2026
Merged
[RDF] Fix display of times in the progress bar.#21277hageboeck merged 1 commit intoroot-project:masterfrom
hageboeck merged 1 commit intoroot-project:masterfrom
Conversation
hageboeck
force-pushed
the
fixProgressBar
branch
from
db432ad to
4c0d5b0
Compare
ea44358 fixed a compilation error on Windows that did not show up in the PRs. This, however, broke the display of times in the progress bar. This commit restores the behaviour without relying on operator<<, but instead using a free function in an anonymous namespace. It's unclear why MSVC didn't find the operator that was initially meant to do this, but by calling a free function, that problem should be gone. Progress bar before: [Elapsed: 2 files: 1 / 1 events: 1000 / 61540413 4.51e+02 evt/s remaining ca.: 136410] Progress bar after: [Elapsed: 0:02m files: 1 / 1 events: 1000 / 61540413 4.54e+02 evt/s remaining ca.: 37:39:42h]
hageboeck
force-pushed
the
fixProgressBar
branch
from
4c0d5b0 to
4cc300e
Compare
martamaja10
approved these changes
Feb 13, 2026
Contributor
martamaja10
left a comment
martamaja10
left a comment
There was a problem hiding this comment.
great, thanks for catching this!
vepadulano
approved these changes
Feb 13, 2026
Test Results 22 files 22 suites 3d 7h 1m 32s ⏱️ Results for commit 4cc300e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ea44358 from #21263 fixed a compilation error on Windows that did not show up in the PR. This, however, broke the display of times in the progress bar.
This commit restores the behaviour without relying on
operator<<, but instead using a free function in an anonymous namespace. It's unclear why MSVC didn't find the operator that was initially meant to do this, but by calling a free function, that problem should be gone.Progress bar before:
[Elapsed: 2 files: 1 / 1 events: 1000 / 61540413 4.51e+02 evt/s remaining ca.: 136410]Progress bar after:
[Elapsed: 0:02m files: 1 / 1 events: 1000 / 61540413 4.54e+02 evt/s remaining ca.: 37:39:42h]