Skip to content

Adds {severity_with_color} as a log format option.#526

Open
alexmaclean6 wants to merge 6 commits intoros2:rollingfrom
alexmaclean6:severity_with_color
Open

Adds {severity_with_color} as a log format option.#526
alexmaclean6 wants to merge 6 commits intoros2:rollingfrom
alexmaclean6:severity_with_color

Conversation

@alexmaclean6
Copy link

@alexmaclean6 alexmaclean6 commented Nov 12, 2025

Description

This change adds a new log formatting token option: {severity_with_color}. When used in the log format string, the severity level will be colorized in the log output, but the rest of the line will not be affected. If RCUTILS_COLORIZED_OUTPUT=1, causing the entire line to be colorized, {severity_with_color} behaves the same as {severity}.

Example usage:

[{severity_with_color}] [{name}]: {message} ({function_name}() at {file_name}:{line_number})

Is this user-facing behavior change?

Yes. It allows users to use {severity_with_color} in their log format.

Did you use Generative AI?

No

Additional Information

Adds {severity_with_color} as a log format option.
b7a4469 
Signed-off-by: Alex MacLean <macleale@amazon.com>
Fix linting errors.
7eca440 
Signed-off-by: Alex MacLean <macleale@amazon.com>
ahcorde
ahcorde requested changes Nov 13, 2025
View reviewed changes
alexmaclean6 and others added 2 commits November 13, 2025 08:03
@alexmaclean6 @ahcorde
Apply suggestions from code review
a728158 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Alex MacLean <alex@macleanfam.org>
Add documentation about to logging.h.
8674a60 
Signed-off-by: Alex MacLean <macleale@amazon.com>
@alexmaclean6 alexmaclean6 requested a review from ahcorde November 14, 2025 17:22
@kscottz
Copy link

kscottz commented Nov 20, 2025

@ahcorde waffle team is assigning this to you. Commenting so I see when it gets merged so I can share it with the community.

ahcorde
ahcorde requested changes Nov 21, 2025
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to add some documentation on ros2_documentation about how to use this new feature ?

@ahcorde
Copy link
Contributor

ahcorde commented Nov 21, 2025 •
edited
Loading

Pulls: #526
Gist: https://gist.githubusercontent.com/ahcorde/c591acc503548d238ce882328cfc0ff0/raw/6ebf6b072064c5bce038503c864fae1a263e4f3c/ros2.repos
BUILD args: --packages-above-and-dependencies rcutils
TEST args: --packages-above rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17570

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@alexmaclean6
Copy link
Author

alexmaclean6 commented Nov 21, 2025

Do you mind to add some documentation on ros2_documentation about how to use this new feature ?

Happy to. I'll update the documentation on Monday, and create a pull request to ros2_documentation.

@alexmaclean6 alexmaclean6 mentioned this pull request Nov 24, 2025
Open
@alexmaclean6
Copy link
Author

alexmaclean6 commented Nov 24, 2025

Added documentation: ros2/ros2_documentation#6045

@alexmaclean6
Copy link
Author

alexmaclean6 commented Nov 24, 2025

@ahcorde - I'm trying to decipher the build failures that you listed. Are those build infrastructure errors? I don't see compile or test failures in the console output. I only see IO Exceptions for Jenkins and Hudson.

@ahcorde
Copy link
Contributor

ahcorde commented Nov 26, 2025 •
edited
Loading

Pulls: #526
Gist: https://gist.githubusercontent.com/ahcorde/3d9575e6cfd65aaddc2e0a40a30c9d01/raw/6ebf6b072064c5bce038503c864fae1a263e4f3c/ros2.repos
BUILD args: --packages-above-and-dependencies rcutils
TEST args: --packages-above rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17617

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya reviewed Dec 5, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexmaclean6 are you still working on this? if you are, can you address the CI failures?

@ahcorde
Copy link
Contributor

ahcorde commented Dec 5, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

ahcorde
ahcorde requested changes Dec 5, 2025
View reviewed changes
@ahcorde
Update src/logging.c
2aaaf97 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor

ahcorde commented Dec 5, 2025

Pulls: #526
Gist: https://gist.githubusercontent.com/ahcorde/6df1f7dbd8f15748f34bd0005880d29b/raw/6ebf6b072064c5bce038503c864fae1a263e4f3c/ros2.repos
BUILD args: --packages-above-and-dependencies rcutils
TEST args: --packages-above rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17700

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya requested changes Dec 7, 2025
View reviewed changes
@ahcorde
Copy link
Contributor

ahcorde commented Dec 11, 2025

friendly ping @alexmaclean6

ahcorde
ahcorde requested changes Dec 17, 2025
View reviewed changes
@ahcorde
review feedback
577636d 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from fujitatomoya December 26, 2025 16:08
@ahcorde
Copy link
Contributor

ahcorde commented Dec 26, 2025

@fujitatomoya I included your suggestions

@ahcorde
Copy link
Contributor

ahcorde commented Dec 26, 2025

Pulls: #526
Gist: https://gist.githubusercontent.com/ahcorde/2800a118ff329635609658a39ad8f9ff/raw/a63ed3d4d474d7f76769407fbedb354207fb325d/ros2.repos
BUILD args: --packages-above-and-dependencies rcutils
TEST args: --packages-above rcutils
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17851

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Dec 28, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Dec 28, 2025

@ahcorde thanks for fixing this.

it does seem like windows failure is related to this PR?

@tonynajjar tonynajjar mentioned this pull request Feb 11, 2026
Open
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Feb 11, 2026

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Feb 11, 2026

rebase

❌ Pull request can't be updated with latest base branch changes

Details

This pull request seems to come from a fork, and Mergify needs the author's permission to update its branch.
The author needs to enable "Allow edits from maintainers" on this pull request, or update the branch manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde requested changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexmaclean6 @kscottz @ahcorde @fujitatomoya