Verify highlighting range is in sync with WikiWord range #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsl
force-pushed
the
verify_range_of_highlighting
branch
from
c67b686 to
82f3432
Compare
rswgnu
approved these changes
Feb 10, 2026
test/hywiki-tests.el
Outdated
| (hywiki-word-at)))) | ||
| "Return potential HyWikiWord and optional #section:Lnum:Cnum at point or nil. | ||
| When `hywiki-tests--with-face-test' is non-nil the HyWikiWord must be | ||
| highlighted to be returned. When it is highlighted the range of the |
Owner
There was a problem hiding this comment.
Add commas in this and next lines.
Collaborator
Author
There was a problem hiding this comment.
Add commas in this and next lines.
I don't know where to add the comma in the second line. Feel free to update that separately or advice me and I'll do it in another update.
* test/hywiki-tests.el (hywiki-tests--word-at): Extend verification to
verify that the range of the WikiWord and the range of the
highlighted text is equal iff a highlighted WikiWord exists.
matsl
force-pushed
the
verify_range_of_highlighting
branch
from
82f3432 to
6773d56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Verify highlighting range is in sync with WikiWord range.
Why
Extend verification to verify that the range of the WikiWord and the
range of the highlighted text is equal iff a highlighted WikiWord
exists.
Note
This is a rework of the proposed change in #850 regarding doing a side effect verification of the ranges. The functionality apart from that is the same.