This repository was archived by the owner on Aug 22, 2025. It is now read-only.
Merged
Conversation
Fix: rtMedia Shortcode [ Develop ]
Version update v1.4.1 [ develop ]
subodhr258
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens the
[rt_media]shortcode against potential XSS and attribute injection vulnerabilities, and improves error handling for invalid or missing media.Changelog
1.4.1 [August 22, 2025]
[rt_media]shortcode attributes.Changes
Security
src,poster, etc.) for video/audio to prevent arbitrary attribute injection.esc_urlfor URLs,esc_attrfor others).absint()onattachment_idto prevent non-integer input.Error Handling / UX
attachment_idis passed.<video>/<audio>players.Why
Testing
[rt_media attachment_id="valid_id"]→ should render media correctly.[rt_media attachment_id="invalid_id"]→ should show "Invalid attachment ID." message.[rt_media attachment_id="valid_id"]where file is missing → should show "Media file unavailable."