-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove API token requirement from Danger workflow #2632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
d7dc3d5 to
eb222e4
Compare
8228003 to
8c59d3e
Compare
83a0487 to
acb1640
Compare
|
Dependent on dblock/danger-changelog#66 now |
| runs-on: ubuntu-latest | ||
| if: github.event.workflow_run.event == 'pull_request' | ||
| steps: | ||
| - name: Checkout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, to have .github/scripts/post-danger-comment.js on "Post or Update PR Comment" step, but maybe I'll just move back to have it inline in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's checking out the code from upstream, right? Otherwise you can inject things here. All good with me.
If possible to package it that'd be best, but can be taken care of later.
| @@ -0,0 +1,82 @@ | |||
| const fs = require('fs'); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any way we can package and release this as part of grape-danger?
|
I'm good with this! Can we move some/most/all of these things into https://github.com/ruby-grape/danger? Otherwise let's work on archiving that repo. |
|
@dblock We can't move workflows totally to ruby-grape-danger. Something will stay here. But we can try to reuse workflows from danger by something like: and |
|
@numbata cool, up to you when you want to refactor |
Switch to tokenless execution using with GitHub Actions annotations for inline feedback. This eliminates the need for the grape-bot token while still providing PR feedback via workflow annotations.
Changes: