Skip to content

Conversation

@tompng
Copy link
Member

@tompng tompng commented Jan 27, 2026

Support upcoming Prism change.
If a node of incomplete code doesn't have closing, node.closing will be nil instead of an empty string.

@tompng
Copy link
Member Author

tompng commented Jan 27, 2026

Fix for closing change in repl_type_completor: ruby/repl_type_completor#68
Test passed locally with gem 'prism', github: 'ruby/prism', branch: 'slices'.
(Fails with undefined method 'empty?' for nil in master branch)

Support upcoming Prism change.
If a node of incomplete code doesn't have closing, node.closing will be nil instead of an empty string.
@tompng tompng force-pushed the prism_slice_closing branch from 696bc87 to 73a5057 Compare January 28, 2026 16:17
@tompng
Copy link
Member Author

tompng commented Jan 28, 2026

This will fix this scheduled CI build failure
https://github.com/ruby/irb/actions/runs/21442733774/job/61749970484

@tompng tompng merged commit 342f57b into ruby:master Jan 28, 2026
38 of 40 checks passed
@tompng tompng deleted the prism_slice_closing branch January 28, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant