Fix resolver incorrectly filtering gems by development self-dependencies#9346
Open
sferik wants to merge 1 commit intoruby:masterfrom
Open
Fix resolver incorrectly filtering gems by development self-dependencies#9346sferik wants to merge 1 commit intoruby:masterfrom
sferik wants to merge 1 commit intoruby:masterfrom
Conversation
`filter_invalid_self_dependencies` checked all dependencies, but should only check runtime dependencies. Development self-dependencies are irrelevant to resolution and should not disqualify a gem version. Resolves ruby#9319.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filter_invalid_self_dependenciesuseds.dependencies, which returns both runtime and development dependencies for locally-installed gems (StubSpecification), but only runtime dependencies for remote gems (EndpointSpecification). This inconsistency caused the resolver to silently drop valid gem versions.In my case,
minitest-bonus-assertions3.0 has a development dependency on itself at ~> 2.0. Since 3.0 doesn't satisfy ~> 2.0, the filter removed it entirely, makingbundle updatefail with "Could not find gem" even though the version exists in the index.The fix changes
s.dependenciestos.runtime_dependencies, since development dependencies are irrelevant to resolution.