Fix validate to respect owned_globs when files specified#89
Open
martinemde wants to merge 1 commit intomainfrom
Open
Fix validate to respect owned_globs when files specified#89martinemde wants to merge 1 commit intomainfrom
martinemde wants to merge 1 commit intomainfrom
Conversation
When validate was called with a file list, it validated all provided files without filtering by owned_globs configuration. This caused files that should be skipped (like .rbi when owned_globs only includes .rb) to be incorrectly reported as unowned. The fix filters file paths by owned_globs and unowned_globs before validation, making behavior consistent with validate without files. Added test using .rbi files to prove the bug existed and verify the fix works correctly.
martinemde
force-pushed
the
martinemde/push-xlvtruwulqtq
branch
from
9e9aa9d to
00c6788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When validate was called with a file list, it validated all provided files without filtering by owned_globs configuration. This caused files that should be skipped (like .rbi when owned_globs only includes .rb) to be incorrectly reported as unowned.
The fix filters file paths by owned_globs and unowned_globs before validation, making behavior consistent with validate without files.