Update custom-emoji #10116
Open
Update custom-emoji #10116
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements three new features:
Context Menu Options
Right clicking an emoji in the chat allows the user to toggle the enabled state of the emoji as well as its resize mode.
Text/Emoji Chat Replacement
Wait, wasn't this already happening? Well, yes. However, there were lots of situations where an emoji just gets unloaded for whatever reason (click the reload button, turn off the plugin, etc), and there would just be a nothing in its place. This change makes it so that if an emoji gets loaded or unloaded, the plugin will parse the chat and update the messages appropriately.
Replacing emoji on plugin shutdown and then the text after plugin startup:
Cycling between the two as the user toggles an emoji, with the state synced between the two interfaces:
Recently downloaded emoji:
Whenever some emoji are downloaded from the repository, you'll now be shown a thingy that will display what's new so you can figure out what changed and also disable something you don't want to see before it shows up in the chat.
