Skip to content

Conversation

@flip1995
Copy link
Member

r? @Manishearth

1 week late, due to vacation and some technical issues.

jieyouxu and others added 30 commits December 6, 2025 15:12
The file is testing `unwrap_used`, but that's already covered by the
`unwrap_expect_used.rs` test file
…Amanieu

Move assert_matches to planned stable path

Another prep PR for rust-lang#137487
The file is testing `unwrap_used`, but that's already covered by the
`unwrap_expect_used.rs` test file

changelog: none
Adds a trailing comma to struct patterns ending with `..`.
Fixes rust-lang#16433
Now, only `call_span` is replaced, so the receiver is not a part of the
diff. This also removes the need to create a snippet for the receiver.
…ust-lang#16198)

Noticed while writing a copy of subtree sync docs for `rustfmt`.

changelog: none
…nishearth

Clippy subtree update

r? Manishearth 

`Cargo.lock` update due to Clippy version bump.
This makes rustc simply return an exit code from main rather than calling `std::process::exit` with an exit code. This means that drops run normally and the process exits cleanly.

Also instead of hard coding success and failure codes this uses `ExitCode::SUCCESS` and `ExitCode::FAILURE`, which in turn effectively uses `libc::EXIT_SUCCESS` and `libc::EXIT_FAILURE` (via std). These are `0` and `1` respectively for all currently supported host platforms so it doesn't actually change the exit code.
…th `..` (rust-lang#16442)

fixes rust-lang/rust-clippy#16433

Adds a trailing comma to the last field of a struct pattern if it ends
with a `..` to avoid an invalid suggestion. A test was added as well.

changelog: [`manual_let_else`] fix suggestion for `..` patterns
std: avoid tearing `dbg!` prints

Fixes rust-lang#136703.

This is an alternative to rust-lang#149859. Instead of formatting everything into a string, this PR makes multi-expression `dbg!` expand into multiple nested matches, with the final match containing a single `eprint!`. By using macro recursion and relying on hygiene, this allows naming every bound value in that `eprint!`.

CC @orlp

r? libs
Closes rust-lang/rust-clippy#16446

changelog: [`doc_markdown`] add PowerShell to whitelist
Related to the example in
rust-lang/rust-clippy#16451 but doesn't fix
the issue itself

changelog: [`let_and_return`]: No longer lints when there's a comment
between the `let` and return
changelog: [`never_loop`]: rhs of short-circuit expression doesn't
always run

Fixes rust-lang/rust-clippy#16462
Closes rust-lang/rust-clippy#16447

changelog: [`test_attr_in_doctest`] fix FP on `test_harness`
…16424)

Closes rust-lang/rust-clippy#16419

changelog: [`manual_is_variant_and`] enhance to cover manual
`is_none_or`
JonathanBrouwer and others added 12 commits February 10, 2026 13:00
…nnethercote

Remove `SubdiagMessage` in favour of the identical `DiagMessage`

For rust-lang#151366
Just some more cleanup :)
SubdiagMessage is now identical to DiagMessage, so there's no point in having both of them
Replace typo'd name with link to the referenced lint.

changelog: none
Fix links linking to non-existent pages.

changelog: none
Marking the `main` function as `#[must_use]` is nonsensical, as it is not really
supposed to be called anyway.
Replace the links to more recent materials in the docs.

changelog: none
Marking the `main` function as `#[must_use]` is nonsensical, as it is
not really supposed to be called anyway.

changelog: [`must_use_candidates`]: No longer lints `main` functions
with return values
)

Triagebot implemented a GitHub comments viewer, it loads and shows all
the comments (and review comments) of an issue or pull-request.

In order to facilitate it's usage we also added a feature to
automatically have triagebot add a "View all comments" link to that
viewer, which this PR enables for this repository with a threshold of 20
comments minimum.

See [this
link](https://triage.rust-lang.org/gh-comments/rust-lang/rust-clippy/issues/15006)
for an example of the result looks like.

cc @samueltardieu
r? @flip1995

changelog: none
r? @ghost

changelog: none
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2026

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. labels Feb 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2026

⚠️ Warning ⚠️

@rust-log-analyzer

This comment has been minimized.

@flip1995 flip1995 force-pushed the clippy-subtree-update branch from 9463913 to 0e2af75 Compare February 12, 2026 13:51
@rust-log-analyzer

This comment has been minimized.

@samueltardieu
Copy link
Member

let_and_return has been relaxed and doesn't trigger anymore when there are comments between the let and the return. The #[expect(clippy::let_and_return)] in compiler/rustc_codegen_gcc/src/declare.rs should be removed.

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2026

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@Manishearth
Copy link
Member

@bors r+ p=1 rollup=never

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 12, 2026

📌 Commit eaad11c has been approved by Manishearth

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 13, 2026

⌛ Testing commit eaad11c with merge 76d6965...

Workflow: https://github.com/rust-lang/rust/actions/runs/21974409176

rust-bors bot pushed a commit that referenced this pull request Feb 13, 2026
Clippy subtree update

r? @Manishearth 

1 week late, due to vacation and some technical issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.