-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add checkout autocomplete settings #6158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
69e24ee
b17b747
01dec1b
68476b8
dab847f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -5446,6 +5446,20 @@ type CheckoutSettings { | |||||||||
| Added in Saleor 3.20. | ||||||||||
| """ | ||||||||||
| automaticallyCompleteFullyPaidCheckouts: Boolean! | ||||||||||
|
|
||||||||||
| """ | ||||||||||
| The time in minutes to wait after a checkout is fully paid before automatically completing it. | ||||||||||
|
|
||||||||||
| Added in Saleor 3.22. | ||||||||||
| """ | ||||||||||
| automaticCompletionDelay: Minute | ||||||||||
|
|
||||||||||
| """ | ||||||||||
| The date time defines the earliest checkout creation date on which fully paid checkouts can begin to be automatically completed. | ||||||||||
|
|
||||||||||
| Added in Saleor 3.22. | ||||||||||
| """ | ||||||||||
| automaticCompletionCutOffDate: DateTime | ||||||||||
| } | ||||||||||
|
|
||||||||||
| """Represents the channel-specific payment settings.""" | ||||||||||
|
|
@@ -5794,13 +5808,13 @@ type Product implements Node & ObjectWithMetadata & ObjectWithAttributes @doc(ca | |||||||||
| """Get a single product media by ID.""" | ||||||||||
| mediaById( | ||||||||||
| """ID of a product media.""" | ||||||||||
| id: ID | ||||||||||
| id: ID! | ||||||||||
| ): ProductMedia | ||||||||||
|
|
||||||||||
| """Get a single product image by ID.""" | ||||||||||
| imageById( | ||||||||||
| """ID of a product image.""" | ||||||||||
| id: ID | ||||||||||
| id: ID! | ||||||||||
|
||||||||||
| id: ID! | |
| id: ID |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation mentions authorize_status but should refer to charge_status instead. This is inconsistent with the schema's own documentation for CheckoutAutoCompleteInput at line 28882, which correctly uses charge_status.
| Default `false`. Determines if the paid checkouts should be automatically completed. This setting applies only to checkouts where payment was processed through transactions.When enabled, the checkout will be automatically completed once the checkout `authorize_status` reaches `FULL`. This occurs when the total sum of charged and authorized transaction amounts equals or exceeds the checkout's total amount. | |
| Default `false`. Determines if the paid checkouts should be automatically completed. This setting applies only to checkouts where payment was processed through transactions. When enabled, the checkout will be automatically completed once the checkout `charge_status` reaches `FULL`. This occurs when the total sum of charged and authorized transaction amounts equals or exceeds the checkout's total amount. |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after "transactions." before "When enabled". There should be a space between these two sentences for proper formatting.
| Default `false`. Determines if the paid checkouts should be automatically completed. This setting applies only to checkouts where payment was processed through transactions.When enabled, the checkout will be automatically completed once the checkout `authorize_status` reaches `FULL`. This occurs when the total sum of charged and authorized transaction amounts equals or exceeds the checkout's total amount. | |
| Default `false`. Determines if the paid checkouts should be automatically completed. This setting applies only to checkouts where payment was processed through transactions. When enabled, the checkout will be automatically completed once the checkout `authorize_status` reaches `FULL`. This occurs when the total sum of charged and authorized transaction amounts equals or exceeds the checkout's total amount. |
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after "transactions." before "When enabled". There should be a space between these two sentences for proper formatting.
Copilot
AI
Dec 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be an unrelated change to the PR's purpose of adding checkout autocomplete settings. Adding the @doc(category: "Attributes") directive to the AttributeBulkUpdateErrorCode enum should be in a separate PR or explained in the PR description.
| enum AttributeBulkUpdateErrorCode @doc(category: "Attributes") { | |
| enum AttributeBulkUpdateErrorCode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be an unrelated change to the PR's purpose of adding checkout autocomplete settings. The change makes the
idparameter required (non-nullable) for themediaByIdfield. This should be in a separate PR or explained in the PR description.