feat: remove --ssr functionality from sites / resolve vulnerabilities @W-20203809#561
Open
feat: remove --ssr functionality from sites / resolve vulnerabilities @W-20203809#561
Conversation
…rabilities @W-20203809@
- Removed all SSR download and metadata management methods - Removed SiteMetadata types and caching - Reduced file from 444 lines to 115 lines (74% reduction) - Only kept methods needed for preview URL generation: - getAllExpSites() - list sites - getPreviewUrl() - get preview URL - getNetworkId() - helper for preview URL - Removed test file for deleted getRemoteMetadata method
nrkruk
changed the title
nrkruk
changed the title
nrkruk
force-pushed
the
nkruk/w20203809-remove-ssr-lwr-dependencies
branch
from
8f43d98 to
af473ed
Compare
- Removed entire 'LWR Sites Development Environment' section - Removed references to yarn link-lwr commands - Removed LWR debugging instructions - Simplified debugging section to focus on plugin debugging only - Updated to be more generic and applicable to all commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes SSR (Server-Side Rendering) functionality and LWR dependencies from the plugin-lightning-dev to resolve critical security vulnerabilities.
Changes made:
--ssrflag from thesf lightning dev sitecommand--get-latestand--guestflags (only used for SSR functionality)@lwrjs/apidependency from package.jsonlink-lwrandunlink-lwrscripts from package.jsonserveSSRSitemethod and related codeisSiteSetupmethod from ExperienceSite classglobdependency to 10.5.0 to fix HIGH severity vulnerability (CVE-2025-64756)Impact:
sf lightning dev sitecommand now only supports the non-SSR preview modeWhat issues does this PR fix or reference?
@W-20203809@