-
Notifications
You must be signed in to change notification settings - Fork 78
Geometry encoding parameter for shapes #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometry encoding parameter for shapes #951
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
==========================================
+ Coverage 92.19% 92.20% +0.01%
==========================================
Files 49 49
Lines 7561 7572 +11
==========================================
+ Hits 6971 6982 +11
Misses 590 590
🚀 New features to boost your workflow:
|
|
Hi @keller-mark, this is ready for review, correct? |
|
Yes, thanks for the reminder, I have just updated the status |
|
Thanks! Doing some light adjustments on the PR. I will push soon. Meanwhile you can find here a benchmark in Python for read-write operations with the new encoding. https://github.com/giovp/spatialdata-sandbox/blob/main/notebooks/benchmark_geoparquet_encoding.ipynb Take home message: write operations are only slightly slower with |
|
Final changes are up. Key points:
|
Fixes #799
The to_parquet function supports a
geometry_encodingparameter. When geoarrow, it will be more efficient to read/parse the geometries, as the data can stay in its parquet/arrow memory layout during downstream usage. Visualization applications will benefit from this (and other applications such as data processing pipelines should too).