-
Notifications
You must be signed in to change notification settings - Fork 60
Fix/remove streams #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Fix/remove streams #1917
Conversation
app/src/main/java/org/thoughtcrime/securesms/database/MmsDatabase.kt
Outdated
Show resolved
Hide resolved
| return Stream.of(slides).filter(Slide::hasImage).toList(); | ||
| } | ||
| public @NonNull List<Slide> getThumbnailSlides() { | ||
| List<Slide> result = new LinkedList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason we want LinkedList instead of a normal ArrayList?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, no good reason. ArrayList is better, I'll update
| String normalizedHighlight = highlight.toLowerCase(locale); | ||
| List<String> highlightTokens = Stream.of(normalizedHighlight.split("\\s")).filter(s -> s.trim().length() > 0).toList(); | ||
|
|
||
| List<String> highlightTokens = new LinkedList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LinkedList?
…ase.kt Co-authored-by: SessionHero01 <180888785+SessionHero01@users.noreply.github.com>
…ation/session-android into fix/remove-streams
SES-4357 - Removed dependency to annimon:Stream