Skip to content

Conversation

@ThomasSession
Copy link
Collaborator

SES-4357 - Removed dependency to annimon:Stream

return Stream.of(slides).filter(Slide::hasImage).toList();
}
public @NonNull List<Slide> getThumbnailSlides() {
List<Slide> result = new LinkedList<>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason we want LinkedList instead of a normal ArrayList?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, no good reason. ArrayList is better, I'll update

String normalizedHighlight = highlight.toLowerCase(locale);
List<String> highlightTokens = Stream.of(normalizedHighlight.split("\\s")).filter(s -> s.trim().length() > 0).toList();

List<String> highlightTokens = new LinkedList<>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LinkedList?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants