Merged
Conversation
Collaborator
SessionHero01
commented
Feb 12, 2026
SessionHero01
commented
- Add stack to API exception and catches a few exceptions
- Try catch PathManager
- Cancellation handling
| ) | ||
| ) | ||
| } catch (e: Exception) { | ||
| if (e !is CancellationException) { |
Collaborator
There was a problem hiding this comment.
Won't you be swallowing the CancellationException now though?
Collaborator
Author
There was a problem hiding this comment.
Yep, will update
| ) | ||
| ) | ||
| } catch (e: Throwable) { | ||
| if (e !is CancellationException) { |
Collaborator
There was a problem hiding this comment.
Same here? Is it ok to absorb the cancellationException?
| @@ -177,6 +178,7 @@ class SnodeDirectory @Inject constructor( | |||
| }.onFailure { e -> | |||
| lastError = e | |||
Collaborator
There was a problem hiding this comment.
I wonder if semantically we should move lastError = e after the CancellationException? I don't think we need to remember CancellationException as the lastException in this case, don't you think?
Collaborator
Author
There was a problem hiding this comment.
Yep happy to update this
ThomasSession
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.