Add overridable parameter #367
Conversation
pull-request-size
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
# Changes: - Add options to NewParams method to allow overriding certain parameters. This can benefit other projects to import this CLI as library. Signed-off-by: Sayan Biswas <sayan-biswas@live.com>
sayan-biswas
force-pushed
the
override-parameters
branch
from
4fd3106 to
43bde3c
Compare
|
/test release-notes-linter |
|
@sayan-biswas: No presubmit jobs available for shipwright-io/cli@main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
adambkaplan
left a comment
adambkaplan
left a comment
There was a problem hiding this comment.
Mostly style nits here - will sleep on this a bit for marking this PR approved.
| return p.follower, nil | ||
| } | ||
|
|
||
| // WithClientset Use explicit clientset |
There was a problem hiding this comment.
nit: use clearer godoc
| // WithClientset Use explicit clientset | |
| // WithClientset updates the shp CLI to use the provided Kubernetes and Build clientsets |
| } | ||
| } | ||
|
|
||
| // WithConfigFlags Use explicit config flags |
There was a problem hiding this comment.
nit: use clearer godoc
| // WithConfigFlags Use explicit config flags | |
| // WithConfigFlags updates the shp CLI to use the provided configuration flags |
| } | ||
| } | ||
|
|
||
| // WithNamespace Use explicit namespace |
There was a problem hiding this comment.
nit: clearer godoc
| // WithNamespace Use explicit namespace | |
| // WithNamespace updates the shp CLI to use the provided namespace |
|
I also recommend adding a release note. Developers who import this repo as a library are end users, too! |
3 participants
Changes
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes