Skip to content

Conversation

@acelaya
Copy link
Member

@acelaya acelaya commented Nov 8, 2025

With PHP 8.4 as the minimum version, NotFoundRedirectConfigInterface can now define properties that implementors can define as readonly or private(set), avoiding the requirement for extra public methods.

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.81%. Comparing base (a731e01) to head (c42fb67).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...ore/src/Config/Options/NotFoundRedirectOptions.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2529      +/-   ##
=============================================
+ Coverage      93.75%   93.81%   +0.06%     
+ Complexity      1724     1703      -21     
=============================================
  Files            279      278       -1     
  Lines           5600     5563      -37     
=============================================
- Hits            5250     5219      -31     
+ Misses           350      344       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acelaya acelaya merged commit c8537e4 into shlinkio:develop Nov 8, 2025
22 of 23 checks passed
@acelaya acelaya deleted the php-8.4-goodies branch November 8, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant