test: add comprehensive tests for extension package #830
+630
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for: - root.go: extension loading and version constraint parsing - config.go: ConfigExtraBundle.ResolvePath method - asset.go: ExtensionAssetConfig methods Also rename test_helper.go to testing_helpers_test.go to follow Go testing conventions. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Resolve conflict in config_test.go by keeping table-driven tests from main and additional test coverage from feature branch. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances test coverage for the extension package by adding comprehensive tests for key functionality and renaming a test helper file to follow Go conventions.
Changes:
- Added tests for
root.gocovering extension detection (apps, plugins, bundles) and version constraint parsing - Added tests for
config.gocovering ConfigExtraBundle methods, ConfigStore methods, config reading, and validation - Added tests for
asset_config.gocovering ExtensionAssetConfig filter methods and entry configuration - Renamed
test_helper.gototesting_helpers_test.gofollowing Go testing naming conventions
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/extension/testing_helpers_test.go | New file (renamed from test_helper.go) containing test helpers including testCheck implementation and image creation utilities |
| internal/extension/root_test.go | New comprehensive tests for extension detection by folder type and Shopware version constraint parsing |
| internal/extension/config_test.go | Added 216 lines of tests covering ConfigExtraBundle path/name resolution, ConfigStore methods, config reading, and validation |
| internal/extension/asset_test.go | Added 91 lines of tests for ExtensionAssetConfig filtering methods and ExtensionAssetConfigEntry behaviors |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for:
Also rename test_helper.go to testing_helpers_test.go to follow Go testing conventions.