Conversation
marc-sift
requested changes
Aug 12, 2025
…e an additional RunForm.
niliayu
reviewed
Aug 18, 2025
niliayu
left a comment
niliayu
left a comment
There was a problem hiding this comment.
Changes look good to me now! Want to make sure @marc-sift is aligned too, and otherwise my questions are more around next steps. Do we want to merge this to main right now and cut the release candidate from main, or merge to a release candidate branch and then merge that branch into main once we're ready to full release? I think the tradeoff with the second option is less time pressure for getting the changes tested, but potential for merge conflict messiness.
marc-sift
requested changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verification
Ailin's benchmarking https://siftstack.atlassian.net/wiki/spaces/sift/pages/1071874168/SiftStreamPy+Benchmarking
Ran her branch and discovered channels weren't being tagged to runs so included fixes to that in my update to her ingestion thread logic she requested. Running our various ingestion examples works as expected.
She re-ran post my changes and saw results consistent w/ initial benchmarking