TT-6891b conditionally display Add New Project... button based on admin status
#176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dmin status - Updated ProjectsScreenInner to include isAdmin check for showing the `Add New Project...` button. - Refactored mountProjectsScreen helper to support mock TeamContext for testing. - Added tests to verify button visibility based on admin status. These changes improve user experience by ensuring that only authorized users can add new projects.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements conditional display of the "Add New Project..." button based on the user's admin status for the selected team. The changes ensure that only team administrators can add new projects, improving the application's access control.
- Conditionally renders the "Add New Project..." button based on admin status
- Updates
isAdminfunction to always return true for personal teams - Adds comprehensive test coverage for both admin and non-admin scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/renderer/src/routes/ProjectsScreen.tsx |
Exports ProjectsScreenInner for testing, adds isAdmin check from context, and conditionally renders the "Add New Project..." button using showAddButton memo |
src/renderer/src/routes/ProjectsScreen.cy.tsx |
Refactors mountProjectsScreen helper to support mock TeamContext, adds tests verifying button visibility for admin and non-admin users |
src/renderer/src/context/TeamContext.tsx |
Updates isAdmin function to return true for personal teams, ensuring users always have admin rights on their own personal team |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add New Project...button.These changes improve user experience by ensuring that only authorized users can add new projects.