-
Notifications
You must be signed in to change notification settings - Fork 4
Refactoring #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Refactoring #9
Conversation
Added tests for TransactionalMatcher
Fixed namespace of the Registry and stop using deprecated methods of the...
…nManagerInterface, added TransactionStatus and fixed ControllerListener to work with new API
…ner to HttpTransactionsListener
…g of AbstractTransactionManager, Introduced TransactionsRegistry to simplify HttpTransactionsListener
…_DOCS to discuss the problems with REQUIRES_NEW transaction type. Add Tests and refactored HttpTransactionsListener.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to send a 500 response without the rollback?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet, but you will be able to specify exceptions not to rollback for in any request.
@Tx\Transactional(noRollbackFor="SomeException")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to extract this logic somehow so I can re-use it in an AOP implementation.
|
A few questions:
I'm not sure whether the implicit scoping is a good idea. It sure is easier to migrate to this bundle then, but in the long term I'm sceptical whether it is good to keep developers unaware of this. It might lead to some code being executed twice (like in constructors) that the developer did not intend to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be inEdges as you are interested in all services that have a dependency on the connection (in contrast to all dependencies that the connection has onto other services).
…. Renamed a bunch of TransactionDefinition constants and general cleanup.
…tor of the form extension
Fixes in 'Refactoring' branch
Refactoring to allow different propagations of requests and clean up the transaction management. Also split up responsibilities.