[HTML] Ensure safe global locale fallback setup#10652
Open
millanzarreta wants to merge 2 commits intosimulationcraft:thewarwithinfrom
Open
[HTML] Ensure safe global locale fallback setup#10652millanzarreta wants to merge 2 commits intosimulationcraft:thewarwithinfrom
millanzarreta wants to merge 2 commits intosimulationcraft:thewarwithinfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in some environments, simc may throw an exception during HTML report creation if the locales
en_US.UTF-8anden_US.utf8do not exist.This PR makes the global locale setup in the HTML report section more robust by adding a fallback mechanism. It tries several common locale names and falls back to
std::locale::classic()(which should never fail) as a last resort.